Skip to content

Conversation

@ecodiv
Copy link
Contributor

@ecodiv ecodiv commented Feb 15, 2025

  • Instead of using 'intermediate pages' with description and link to external tutorials, it is possible to directly link to the external tutorials. Added cards for three tutorials (including a new one) that use this direct link.
  • Include the rule in the yaml to open external tutorials in a new tab.
  • Add a post card image for the 'Get started with GRASS in Jupyter Notebooks on Windows'
  • Add post card image for the 'Making plots with GRASS GIS'

- Instead of using 'intermediate pages' with description and link to external tutorials, it is possible to make a directly link to the external tutorials.
- Added cards for two tutorials
- I included the rule in the yaml to open external tutorials in a new tab.
- Added a post card image for the 'Get started with GRASS in Jupyter Notebooks on Windows'
- Added a post card image for the 'Making plots with GRASS GIS'
@ecodiv
Copy link
Contributor Author

ecodiv commented Feb 15, 2025

@veroandreo @petrasovaa @wenzeslaus and @chaedri, I can't add a review request, so doing it this way. Two specific questions:

  • I added two tutorials using a direct link. I prefer it as it is less work, and it save the user a click. What do you think?
  • The image of the tutorial cards by default use the first image in the tutorial. In some cases, these images seem less suitable (not the most representative for that post, or with the wrong dimensions). I added suggestions for images for two tutorials.

I only changed the source, not the branch with the html yet. I guess it is more logical to have the source merged / approved before changing the branch with the html (#19).

Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is good, but please move all your posts into another file like that (see documentation):

--- a/index.qmd
+++ b/index.qmd
@@ -3,6 +3,7 @@ title: "Learn GRASS GIS"
 listing:
     contents: 
         - content/tutorials
+        - content/tutorials/external/ecodiv.yml
     sort: "date desc"
     type: grid
     categories: true

There are some unrelated changes, so perhaps do those in separate PR, makes it easier to review.

@petrasovaa
Copy link
Contributor

Also regarding the dates of the posts, I try to make them represent the date of the original material, not the date of the posting, partially because I want to have the latest material on top.

@ecodiv
Copy link
Contributor Author

ecodiv commented Feb 17, 2025

The idea is good, but please move all your posts into another file like that (see documentation):

--- a/index.qmd
+++ b/index.qmd
@@ -3,6 +3,7 @@ title: "Learn GRASS GIS"
 listing:
     contents: 
         - content/tutorials
+        - content/tutorials/external/ecodiv.yml
     sort: "date desc"
     type: grid
     categories: true

There are some unrelated changes, so perhaps do those in separate PR, makes it easier to review.

Ah, yes, that's also possible, will do that.

@ecodiv
Copy link
Contributor Author

ecodiv commented Feb 17, 2025

Also regarding the dates of the posts, I try to make them represent the date of the original material, not the date of the posting, partially because I want to have the latest material on top.

Agree, and I thought I did that, but perhaps not, will check.

@ecodiv
Copy link
Contributor Author

ecodiv commented Feb 21, 2025

Also regarding the dates of the posts, I try to make them represent the date of the original material, not the date of the posting, partially because I want to have the latest material on top.

Agree, and I thought I did that, but perhaps not, will check.

Done (for one post, I did indeed use the date of a previous version)

@ecodiv
Copy link
Contributor Author

ecodiv commented Feb 21, 2025

The idea is good, but please move all your posts into another file like that (see documentation):

--- a/index.qmd
+++ b/index.qmd
@@ -3,6 +3,7 @@ title: "Learn GRASS GIS"
 listing:
     contents: 
         - content/tutorials
+        - content/tutorials/external/ecodiv.yml
     sort: "date desc"
     type: grid
     categories: true

There are some unrelated changes, so perhaps do those in separate PR, makes it easier to review.

Ah, yes, that's also possible, will do that.

Done

@ecodiv
Copy link
Contributor Author

ecodiv commented Feb 21, 2025

There are some unrelated changes, so perhaps do those in separate PR, makes it easier to review.

Removed the proposed feature images for two posts, will create a separate PR for that.

@ecodiv
Copy link
Contributor Author

ecodiv commented Feb 21, 2025

@petrasovaa I implemented your suggestions. Do you mind having a look? Thanks

ecodiv and others added 2 commits February 22, 2025 10:55
Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
@petrasovaa
Copy link
Contributor

I fixed it. I don't know if that is the problem, but make sure you follow the github contributing guidelines we have linked in README. You were creating a PR from your main branch, but you need to create a branch from your rebased main. At this point it may be easiest for you to remove your fork and fork it again to ensure future PRs are correct.

@petrasovaa petrasovaa merged commit e7327e7 into OSGeo:main Feb 26, 2025
@petrasovaa
Copy link
Contributor

Please check the website (once deployed) is good just in case I missed something.

@ecodiv
Copy link
Contributor Author

ecodiv commented Feb 28, 2025

Please check the website (once deployed) is good just in case I missed something.

Thanks, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants