-
Notifications
You must be signed in to change notification settings - Fork 22
Add two tutorials and card images #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Instead of using 'intermediate pages' with description and link to external tutorials, it is possible to make a directly link to the external tutorials. - Added cards for two tutorials - I included the rule in the yaml to open external tutorials in a new tab. - Added a post card image for the 'Get started with GRASS in Jupyter Notebooks on Windows' - Added a post card image for the 'Making plots with GRASS GIS'
|
@veroandreo @petrasovaa @wenzeslaus and @chaedri, I can't add a review request, so doing it this way. Two specific questions:
I only changed the source, not the branch with the html yet. I guess it is more logical to have the source merged / approved before changing the branch with the html (#19). |
petrasovaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is good, but please move all your posts into another file like that (see documentation):
--- a/index.qmd
+++ b/index.qmd
@@ -3,6 +3,7 @@ title: "Learn GRASS GIS"
listing:
contents:
- content/tutorials
+ - content/tutorials/external/ecodiv.yml
sort: "date desc"
type: grid
categories: true
There are some unrelated changes, so perhaps do those in separate PR, makes it easier to review.
|
Also regarding the dates of the posts, I try to make them represent the date of the original material, not the date of the posting, partially because I want to have the latest material on top. |
Ah, yes, that's also possible, will do that. |
Agree, and I thought I did that, but perhaps not, will check. |
Done (for one post, I did indeed use the date of a previous version) |
Done |
Removed the proposed feature images for two posts, will create a separate PR for that. |
|
@petrasovaa I implemented your suggestions. Do you mind having a look? Thanks |
...ze/content/tutorials/get_started/JupyterOnWindows_OSGeo4W_Tutorial/execute-results/html.json
Show resolved
Hide resolved
content/tutorials/get_started/images/getting_started_grass_jupyternotebook.png
Show resolved
Hide resolved
Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
|
I fixed it. I don't know if that is the problem, but make sure you follow the github contributing guidelines we have linked in README. You were creating a PR from your main branch, but you need to create a branch from your rebased main. At this point it may be easiest for you to remove your fork and fork it again to ensure future PRs are correct. |
|
Please check the website (once deployed) is good just in case I missed something. |
Thanks, looks good! |
Uh oh!
There was an error while loading. Please reload this page.