wxGUI: Fix PTH208 use pathlib Path instead of os module#5461
Merged
echoix merged 2 commits intoOSGeo:mainfrom Apr 1, 2025
Merged
wxGUI: Fix PTH208 use pathlib Path instead of os module#5461echoix merged 2 commits intoOSGeo:mainfrom
echoix merged 2 commits intoOSGeo:mainfrom
Conversation
echoix
requested changes
Mar 31, 2025
Member
echoix
left a comment
There was a problem hiding this comment.
Sorry, I had the comment and review last week done for this, but it didn't send, maybe I had a week cell connection at that time and left right after.
So, this one is also weird, we usually don't comment on all the lines like this, and you usually don't either, so was this a new tool or AI of some kind? Do you still review the same way the work that is made?
echoix
approved these changes
Apr 1, 2025
Kiraschild
pushed a commit
to Kiraschild/grass
that referenced
this pull request
Apr 4, 2025
* added pathlib * removed comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR addresses the PTH208 linting error in gui/wxpython/icons/grass_icons.py by replacing os.listdir and os.path.splitext with their pathlib equivalents.