v.overlay: do not use invalid centroids#7338
Merged
metzm merged 1 commit intoOSGeo:mainfrom Apr 23, 2026
Merged
Conversation
metzm
added
bug
nilason
approved these changes
Apr 23, 2026
Contributor
Author
|
Some tests fail because there is again some mess in |
Contributor
These seemingly random, immensely difficult to debug failures. |
Contributor
Author
Looks like fortran code translated to C without sanity checks, and then parallelized. There must be numerical instability somewhere. Different issue, thanks for triggering the re-run! |
metzm
added a commit
that referenced
this pull request
Apr 23, 2026
metzm
added a commit
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, this PR ensures that
v.overlaydoes not use invalid centroids in the result. These invalid centroids can lead to duplicate centroids or centroids outside any area in the output.