Consume ignored responses in the ERM sample#122
Merged
berezovskyi merged 4 commits intomasterfrom Aug 23, 2022
Merged
Conversation
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
jadelkhoury
approved these changes
Aug 19, 2022
This is because some parts of the code try to read the response stream multiple times. Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't have a chance to test yet. Written in response to https://forum.open-services.net/t/rmsample-connectionclosedexception-exception/651/5Tested on ELM 7.0.2.I also think we should not be writing such code in consumer code and the client should help with those actions.