Skip to content

Conversation

@berezovskyi
Copy link
Member

No description provided.

Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi berezovskyi requested a review from Copilot July 12, 2025 16:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes minimal changes to restore compatibility with modern Node versions by updating HTML entity decoding, module exports, build scripts, and environment configurations.

  • Use the decode function from html-entities instead of instantiating XmlEntities
  • Change DefaultFilters to an ES default export
  • Upgrade scripts/dependencies (react-scripts, add psl, tough-cookie, browserslist) and configure legacy OpenSSL flags in CI and .env

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/ResourceItem.js Swapped XmlEntities instantiation for decode() import
src/ResourceGraph.js Updated decoding calls and entity import
src/PreviewDialog.js Replaced entities.decode with decode()
src/DefaultFilters.js Converted CommonJS export to ES default export
package.json Added new dependencies, bumped react-scripts, added browserslist
.github/workflows/node.yml Set NODE_OPTIONS: --openssl-legacy-provider for build
.env Added SKIP_PREFLIGHT_CHECK and legacy OpenSSL flag
Comments suppressed due to low confidence (3)

src/PreviewDialog.js:20

  • [nitpick] This variable shadows the global document object. Consider renaming it to something like iframeSrc or decodedDocument.
  	let document = decode(dialog?dialog.document:'');

src/ResourceGraph.js:172

  • This fallback duplicates the previous getTitle() call. It likely should use getShortTitle() instead of repeating getTitle().
						    if (!label) label = targetResource.getTitle();

.env:1

  • Committing a .env file can risk exposing environment settings. Consider adding .env to .gitignore and providing a .env.example instead.
SKIP_PREFLIGHT_CHECK=true

Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi berezovskyi merged commit 0ad92ec into main Jul 12, 2025
4 checks passed
@berezovskyi berezovskyi deleted the b-fix-build branch July 12, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants