Sets login sessions to permanent for longer login sessions#73
Merged
Merged
Conversation
This change makes it so Flask's session cookie is stored with an explicit expiration date. This means that, rather than the login expiring after the browser closes (expiration = 'Session'), it expires on an explicit date. By default, 31 days.
Contributor
Author
|
Also, sorry about the whitespace changes - I didn't notice my IDE had done so until after I created the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it so Flask's session cookie is stored with an explicit expiration date. This means that, rather than the login expiring after the browser closes (expiration = 'Session'), it expires on an explicit date. By default, 31 days.
The duration could be modified, e.g. with the following line in taskapp.py:
However, given the insensitive nature of the data in this application, I would not bother.