chromium-ozone-wayland: Stop depending on the system's wayland-scanne…#278
Merged
Merged
Conversation
…r binary This commit re-applies the changes of the commit given below to the current chromium-ozone-wayland recipe as they got lost in the meantime. | commit cd88d7b | Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Date: Thu May 2 12:08:54 2019 +0200 | | chromium-ozone-wayland: Stop depending on the system's wayland-scanner | binary | | So far, we were using Chromium's default GN path for the system | wayland-scanner binary, "/usr/bin/wayland-scanner", which may not be present | at all and which should never be used anyway. Instead, we now point to the | version built by the wayland-native recipe. | | Doing so of course requires depending on wayland-native in the first place, | and that requires adding back REQUIRED_DISTRO_FEATURES and a DEPENDS block | that got removed with no explanation when the recipe was updated to | M72 (commit 97876fa, "chromium: Update to 72.0.3626.81"). | | Fixes OSSystems#241 | | Signed-off-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Fixes: 1f363e2 ("chromium: Update to 74.0.3729.131") Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
rakuco
approved these changes
Jun 27, 2019
Collaborator
rakuco
left a comment
rakuco
left a comment
There was a problem hiding this comment.
lgtm, thank you for noticing this had broken again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r binary
This commit re-applies the changes of the commit given below to the current
chromium-ozone-wayland recipe as they got lost in the meantime.
| commit cd88d7b
| Author: Raphael Kubo da Costa raphael.kubo.da.costa@intel.com
| Date: Thu May 2 12:08:54 2019 +0200
|
| chromium-ozone-wayland: Stop depending on the system's wayland-scanner
| binary
|
| So far, we were using Chromium's default GN path for the system
| wayland-scanner binary, "/usr/bin/wayland-scanner", which may not be present
| at all and which should never be used anyway. Instead, we now point to the
| version built by the wayland-native recipe.
|
| Doing so of course requires depending on wayland-native in the first place,
| and that requires adding back REQUIRED_DISTRO_FEATURES and a DEPENDS block
| that got removed with no explanation when the recipe was updated to
| M72 (commit 97876fa, "chromium: Update to 72.0.3626.81").
|
| Fixes #241
|
| Signed-off-by: Raphael Kubo da Costa raphael.kubo.da.costa@intel.com
Fixes: 1f363e2 ("chromium: Update to 74.0.3729.131")
Signed-off-by: Ulrich Ölmann u.oelmann@pengutronix.de