Move DisplayInterface.GetDeviceDescription code to DeviceDescription.Parse#35
Merged
rpavlik merged 2 commits intoOSVR:masterfrom Mar 24, 2015
Merged
Conversation
…layInterface.GetDeviceDescription over to to this static method.
Member
|
Good thought, thanks for the patch. |
rpavlik
added a commit
that referenced
this pull request
Mar 24, 2015
Move DisplayInterface.GetDeviceDescription code to DeviceDescription.Parse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeviceDescription should have a static Parse method taking a json string value to handle parsing of the DeviceDescription. DisplayInterface.GetDeviceDescription should still handle sourcing the json value (either a static value or from '/display').
This will make it easier to migrate DeviceDescription into the core Managed-OSVR library in the future.