Fix missing escapes on wave scripts #78
Merged
JimLewis merged 1 commit intoOSVVM:mainfrom Feb 24, 2026
Merged
Conversation
The wave script was being sourced at point when the ScriptFile was being created, instead of when the ScriptFile is eventuallly sourced. Leading to regressed behaviour vs previous release.
Member
|
Thanks |
Member
|
Please do pull requests against dev branch rather than main. I will fix this on my side to make sure it gets fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wave script was being sourced at point when the ScriptFile was being created, instead of when the ScriptFile is eventually sourced. Leading to regressed behaviour vs previous release.
I tested this fix with Questa Base 2025.1.
Prior to the fix, the generated script just has a
if {0} {line instead of the sourcing of the script.I was seeing odd behaviour where my simulator groups were showing up, but none of the signals. This fix resolves that so the wave.do script is sourced at the appropriate time.
It does add to the untested GUI behaviour in the latest release.