Fix commercial averages scoring bug: restore * 100 scaling#291
Merged
davewichers merged 1 commit intoOWASP-Benchmark:generalizeScoringfrom Apr 13, 2026
Conversation
…cumulation The CategoryResults -> CategoryMetrics refactor accidentally dropped the * 100 multiplier from the commercial score variable in ScatterVulns.makeLegend(), causing commercial averages to display as 0/1 instead of proper percentages. The non-commercial score accumulation was also missing * 100, causing the overall average (which blends commercial + non-commercial totals) to mix 0-1 rates with 0-100 percentages. Fix: add * 100 to both score accumulation paths, matching the existing display-score pattern already used for low/high comparison at line 386. Test values in CommercialAveragesTableTest were simultaneously scaled from 0-1 to 0-100 during the refactor, masking the bug (two errors cancelling out). Reverted to 0-1 rates to match what calculateMetrics() produces in production. All test assertions unchanged -- same expected output.
davewichers
merged commit 91b44c4
into
OWASP-Benchmark:generalizeScoring
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
All existing test assertions unchanged — same expected output (47, 38, 62, 58, etc.)
Additional bugs found in generalizeScoring