refactor: replace magic strings with Severity and LLMProvider enums (#47)#81
Merged
advaitpatel merged 1 commit intoMay 18, 2026
Conversation
…WASP#47) Adds docksec/enums.py with Severity and LLMProvider (both extend str for backwards-compatible comparisons and JSON serialisation). All hardcoded provider/severity string lists across config_manager.py, docker_scanner.py, score_calculator.py, utils.py, and cli.py now source from the enums. argparse provider choices are driven by LLMProvider.values(). Tests updated to use Severity.values().
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage ? 27.23%
=======================================
Files ? 15
Lines ? 1788
Branches ? 0
=======================================
Hits ? 487
Misses ? 1301
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
advaitpatel
approved these changes
May 18, 2026
Collaborator
advaitpatel
left a comment
advaitpatel
left a comment
There was a problem hiding this comment.
lgtm, thank you for your contributions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47
Description
Severity levels (
CRITICAL,HIGH,MEDIUM,LOW,UNKNOWN) and LLMprovider names (
openai,anthropic,google,ollama) were repeated asraw strings across 6+ files, making them typo-prone and hard to discover.
Files Changed
docksec/enums.pySeverityandLLMProviderenumsdocksec/config_manager.pydocksec/docker_scanner.pydocksec/score_calculator.pySEVERITY_WEIGHTSdict keyed by enumdocksec/utils.pyLLMProviderconstants inget_llmbranchesdocksec/cli.pyLLMProvider.values()for argparse choicestests/test_docker_scanner.pySeverity.values()Type of Change
How Has This Been Tested?
Test Configuration:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.