Skip to content

Fix Silent Infrastructure Test Skip#4686

Merged
arkid15r merged 2 commits into
OWASP:mainfrom
rudransh-shrivastava:fix/infrastructure-tests-skip-bug
May 16, 2026
Merged

Fix Silent Infrastructure Test Skip#4686
arkid15r merged 2 commits into
OWASP:mainfrom
rudransh-shrivastava:fix/infrastructure-tests-skip-bug

Conversation

@rudransh-shrivastava
Copy link
Copy Markdown
Collaborator

Proposed change

Fix https://github.com/OWASP/Nest/actions/runs/25838501232/job/75918729786#step:4:1

Checklist

  • Required: I followed the contributing workflow
  • Required: I verified that my code works as intended and resolves the issue as described
  • Required: I ran make check-test locally: all warnings addressed, tests passed
  • I used AI for code, documentation, tests, or communication related to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a9b2ca7e-4a7f-42cf-86db-53e341afc991

📥 Commits

Reviewing files that changed from the base of the PR and between c37f8ad and 125f828.

📒 Files selected for processing (1)
  • infrastructure/Makefile

Summary by CodeRabbit

Release Notes

No user-visible changes. This release includes internal infrastructure maintenance improvements to the test execution process.

  • Chores
    • Optimized internal test discovery and execution workflow.

Walkthrough

The test-infrastructure Makefile target's directory discovery logic is refactored to filter out .terraform directories and to use line-based path reading instead of null-delimited iteration. The terraform init and test invocations remain unchanged.

Changes

Infrastructure Test Discovery

Layer / File(s) Summary
Test directory discovery loop
infrastructure/Makefile
The find command filters out */.terraform/* paths via -not -path, and the path iteration switches from null-delimited (-print0 / read -d '') to line-based (IFS= read -r).

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix Silent Infrastructure Test Skip' directly relates to the main change: fixing a silent skip in infrastructure tests by correcting the find/read loop invocation.
Description check ✅ Passed The description is related to the changeset, referencing a specific GitHub Actions run that documents the infrastructure test issue being fixed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

PR validation failed: No linked issue and no valid closing issue reference in PR description

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.92%. Comparing base (6ed207f) to head (a3aa788).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4686   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         528      528           
  Lines       16968    16968           
  Branches     2364     2416   +52     
=======================================
  Hits        16785    16785           
  Misses         98       98           
  Partials       85       85           
Flag Coverage Δ
backend 99.50% <ø> (ø)
frontend 97.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ed207f...a3aa788. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rudransh-shrivastava rudransh-shrivastava marked this pull request as ready for review May 16, 2026 07:53
@sonarqubecloud
Copy link
Copy Markdown

@arkid15r arkid15r enabled auto-merge May 16, 2026 17:26
@arkid15r arkid15r added this pull request to the merge queue May 16, 2026
Merged via the queue into OWASP:main with commit 1c59908 May 16, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants