Master for upstream Adding a NoSQL Injection vulnerability tidy ups#85
Merged
ckarande merged 7 commits intoFeb 22, 2017
Conversation
Beautified: user-dao.js session.js a1.html server.js profile-test.js allocations.html user-dao.js Moved comparePassword as jshint complained that it was used before it was defined.
Member
|
@binarymist Thanks for the updates. As usual, I commend your commitment to code quality and consistency. Would you be able to fix references to point to the OWASP NodeGoat repo in indicated in my comments in README.md? Rest of the changes are great and good to merge. |
ckarande
reviewed
Feb 14, 2017
| * Clone the github repository | ||
| ``` | ||
| git clone https://github.com/OWASP/NodeGoat.git | ||
| git clone https://github.com/binarymist/NodeGoat.git |
Member
There was a problem hiding this comment.
Apparently, an unintenational change, please point the URL it to OWASP repo. Also same applies to lines 93 and 109.
Collaborator
Author
There was a problem hiding this comment.
Good spotting, every so often those slip through, I'll fix these when soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #81