Skip to content

Fix - userId variable isnt set when viewing the memos page#89

Merged
ckarande merged 3 commits into
OWASP:masterfrom
lirantal:fix/lost-userid-on-template
Mar 7, 2017
Merged

Fix - userId variable isnt set when viewing the memos page#89
ckarande merged 3 commits into
OWASP:masterfrom
lirantal:fix/lost-userid-on-template

Conversation

@lirantal
Copy link
Copy Markdown
Collaborator

Fixes #88

@lirantal
Copy link
Copy Markdown
Collaborator Author

@binarymist @ckarande I can't assign any of you as reviewers, would be nice in the future.

@ckarande
Copy link
Copy Markdown
Member

@lirantal The changes look good and fixes the issue. Do you mind running grunt precommit and take care of any linting rules before I merge this PR. Thanks

@lirantal
Copy link
Copy Markdown
Collaborator Author

lirantal commented Mar 6, 2017

Sure @ckarande, I commited a fix with all out-standing jsbeautify items resulted from grunt precommit with the exception of small long lines linting on test/security/profile-test.js which I didn't touch and I'll skip for now.

@ckarande
Copy link
Copy Markdown
Member

ckarande commented Mar 7, 2017

@lirantal This is great! Thanks

@ckarande ckarande merged commit dcb7c73 into OWASP:master Mar 7, 2017
@lirantal
Copy link
Copy Markdown
Collaborator Author

lirantal commented Mar 7, 2017

My pleasure, thanks for keeping up with this great project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants