Duplicated code refactor #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… aggregate. what : 1. we can just pass aggregate query and data connection object on which aggregate to apply on. 2. all examples on internet use it this way (for eg: http://zetcode.com/python/pymongo/)
what : according to rest conventions if the object is just retrieving from database its a GET call ,POST call is when you create an object in database 2.also URI names should not contain underscores and instead hyphens because its good for readability. 3. the name should be an explicit noun ,which is clear and understood. source : https://restfulapi.net/resource-naming/
…/all events what : combined the network events and by date ,and similarly for honeypot events and all events also removed the POST call according to convention also made the changes in the web js part
what : combined get_network_events and get_network_events_by_date also renamed get_network_events to network-events and so on
what: combined top honeypot event ips /by date/by country/by country and date together
what: combined honeypot/network events ips by date,country,country and date together and made changes in the web ui
what : refactored the code for honeypot/network events ports ,ports by country,date,country and date.
what : refactored the routes for getting top machinenames
what: combined the top honeypot countries and by date similarly for network events
what: i changed the uri names in the code so i changed the names in the js file which is calling the URI's
Ali-Razmjoo
approved these changes
Jun 2, 2019
This was referenced Jun 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ali-Razmjoo : created the branch here ! and would push all commits related to refactoring on this branch!
related to #27 : I followed some of the REST api conventions from https://restfulapi.net/resource-naming/
and also in the commit messages i have mentioned what is done per commit