Skip to content

Feature/add-dropdown : Version Routing implementation#2355

Merged
sydseter merged 2 commits intoOWASP:masterfrom
prakhar0x01:feature/add-dropdown
Feb 23, 2026
Merged

Feature/add-dropdown : Version Routing implementation#2355
sydseter merged 2 commits intoOWASP:masterfrom
prakhar0x01:feature/add-dropdown

Conversation

@prakhar0x01
Copy link
Copy Markdown
Contributor

Issue Fixed : #2233

📌 Overview

This PR improves version and language handling for card routes and resolves multiple issues related to routing, SSR failures, and edge cases.

It ensures consistent navigation behavior across editions, versions, and languages while improving overall UX stability.


✅ What This PR Fixes

1️⃣ SSR Build Failure

  • Fixed ReferenceError: versions is not defined

  • Properly passed and destructured versions using Svelte 5 runes mode ($props())

  • Ensured no undefined variables during prerender


2️⃣ Incorrect Route Generation

  • Replaced outdated /card/... paths with correct /edition/... routes

  • Prevented 404 errors caused by invalid URL generation

  • Restored navigation for:

    • /cards

    • /edition/webapp

    • /edition/mobileapp


3️⃣ Duplicate Languages in Dropdown

  • Removed repeated language entries using Set

  • Ensured language list renders uniquely


4️⃣ Version 3.0 Language Restriction

  • Version 3.0 now correctly displays only English (en)

  • Dropdown dynamically adapts based on selected version


5️⃣ Edge Case Handling (UX Improvement)

When switching versions:

  • If user is on:

    /edition/.../2.2/fr

  • And switches to 3.0

They are now automatically redirected to:

/edition/.../3.0/en

Instead of encountering a 404.

This prevents invalid version-language combinations and improves user experience.


🧪 Testing

  • Verified successful pnpm build (SSR + prerender)

  • Confirmed no 404s during version/language switching

  • Tested edge cases:

    • Switching versions across languages

    • Switching languages across versions

    • Version 3.0 language enforcement

Screen.Recording.2026-02-24.at.01.32.56.mov

🎯 Result

  • No SSR crashes

  • No broken routes

  • No duplicate languages

  • Clean navigation behavior

  • Improved UX for edge cases


@prakhar0x01
Copy link
Copy Markdown
Contributor Author

@sydseter ,

Sorry for the delay,
Please review

Thank,
@prakhar0x01

@sydseter sydseter merged commit 1d407ad into OWASP:master Feb 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add version drop down for the individual card pages

2 participants