Skip to content

fix: guide template page breaks and card back interleaving (#2133)#2746

Merged
sydseter merged 14 commits intoOWASP:masterfrom
Adarshkumar0509:fix/guide-template-layout-and-back-pages
Apr 19, 2026
Merged

fix: guide template page breaks and card back interleaving (#2133)#2746
sydseter merged 14 commits intoOWASP:masterfrom
Adarshkumar0509:fix/guide-template-layout-and-back-pages

Conversation

@Adarshkumar0509
Copy link
Copy Markdown
Contributor

@Adarshkumar0509 Adarshkumar0509 commented Mar 28, 2026

Resolves #2133

Description

Changes
scripts/convert.py

  • Fixed _validate_command_args() to skip backslash check on the
    executable path argument on Windows, allowing LibreOffice PDF
    conversion to work correctly on Windows systems

resources/templates/owasp_cornucopia_webapp_ver_guide_bridge_lang.odt

  • Added page break before Frequently Asked Questions section so it always starts at the top of a new page
  • Inserted card back page after each suit's front card sheet so the guide can be printed front and back naturally on a desktop printer

resources/templates/owasp_cornucopia_webapp_ver_guide_bridge_qr_lang.odt

  • Applied same fixes as bridge template above

Testing

  • Tested locally on Windows with Python 3.13 and LibreOffice
  • Verified FAQ starts at top of new page in generated PDF
  • Verified blue back page follows each card front sheet
  • Tested bridge template with all 10 languages: en, es, fr, nl, no-nb, pt-br, pt-pt, it, ru, hu — all pass
  • Tested bridge_qr template with all available languages all pass

Note on CI failures

  • Build and run COPI Tests failure is pre-existing and unrelated to this PR, only Python scripts and ODT templates were modified

All fixes were verified locally by generating and inspecting the PDF output.

AI Tool Disclosure

  • Yes My contribution does not include any AI-generated content .All things are done by me

Affirmation

@Adarshkumar0509
Copy link
Copy Markdown
Contributor Author

Adarshkumar0509 commented Mar 29, 2026

@sydseter is this looks good to you image
and
image and also done back side .
image

@Adarshkumar0509
Copy link
Copy Markdown
Contributor Author

@sydseter sir I also verified for 2-3 other languages also my fix is working .

@sydseter
Copy link
Copy Markdown
Collaborator

sydseter commented Apr 8, 2026

@Adarshkumar0509 there is a conflict you need to resolve.

@sydseter
Copy link
Copy Markdown
Collaborator

sydseter commented Apr 8, 2026

I have added some additional comment in the issue. I think it would be better if we change the direction a little.

@Adarshkumar0509
Copy link
Copy Markdown
Contributor Author

Yeah sure from now I will also try to inc coverage to 95.

@Adarshkumar0509
Copy link
Copy Markdown
Contributor Author

hii @sydseter sir, have a look at this and The ClusterFuzzLite failures are caused by mypy==1.20.0 introducing an unpinned librt dependency on master unrelated to my changes. Please review when you get a chance.

@Adarshkumar0509
Copy link
Copy Markdown
Contributor Author

If you have any suggestions on how I could have approached this better or anything I missed, I'd really appreciate the feedback it will help me improve.

@Adarshkumar0509
Copy link
Copy Markdown
Contributor Author

hii @sydseter sir , can you take a look at this?

@OWASP OWASP deleted a comment from github-actions Bot Apr 19, 2026
@OWASP OWASP deleted a comment from github-actions Bot Apr 19, 2026
@OWASP OWASP deleted a comment from github-actions Bot Apr 19, 2026
@OWASP OWASP deleted a comment from github-actions Bot Apr 19, 2026
@OWASP OWASP deleted a comment from github-actions Bot Apr 19, 2026
@sydseter
Copy link
Copy Markdown
Collaborator

This is a step in the right direction.

@sydseter sydseter merged commit 653af63 into OWASP:master Apr 19, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the layout on the guide templates

2 participants