fix: replace structural <span> wrappers with semantic headings (<h1>, <h2>)#2827
Merged
sydseter merged 10 commits intoOWASP:masterfrom Apr 19, 2026
Merged
Conversation
… a11y and SEO Resolves accessibility and SEO issues on the landing page by properly formatting title wrappers to semantic headings, and updating CSS accordingly.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the semantic structure of the landing page by replacing non-semantic <span> title wrappers with proper heading elements, aiming to improve accessibility (screen-reader navigation) and SEO.
Changes:
- Replaced the main title wrapper with an
<h1>and subsequent title wrappers with<h2>on the home route. - Updated the page-scoped CSS to style
h1, h2instead of globally stylingspan.
Deleted impossible fallback traces and simplified error catching logic in Health/Api controllers. Eliminated unreachable branches and added specific Vitest maps to bump frontend branch coverage.
…o achieve 100% component coverage
…aim missed coverage lines
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…returning false negatives
…nfig hook trace to solidify coverage margin
Contributor
Author
|
Hey @sydseter , have a look at this whenevr you have time. |
…ation to satisfy strict vitest assertions
sydseter
approved these changes
Apr 19, 2026
Collaborator
|
@Mysterio-17 Thank you for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an accessibility (a11y) and SEO issue on the landing page where the primary page titles were being rendered using un-classed tags rather than proper HTML document headings.
Previously, home.h1.1, home.h1.2, and home.h1.3 were wrapped in tags, which broke screen-reader navigation and search-crawler context. To make them visually appear as headers, a global styling block was originally applied to all span components, which made future inline styling brittle.
Fixes: #2826
Solution
<h1>tag to establish the root document hierarchy.<h2>tags.AI Usage
AI was used to help format this PR description. The code analysis, HTML/CSS changes, and solution logic are entirely my own work and free of AI-generated noise and unnecessary comments.