Skip to content

Fix: Restructure Dockerfile for cornucopia.owasp.org build context #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sydseter merged 1 commit into from
Apr 19, 2026
+20 −14
Merged

Fix: Restructure Dockerfile for cornucopia.owasp.org build context #2840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/zap-nightly-scan-website.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ jobs:
- name: Checkout repository
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Copy source data into build context
run: cp -r source cornucopia.owasp.org/source

- name: Build website Docker image
run: docker build -t cornucopia-website -f cornucopia.owasp.org/Dockerfile cornucopia.owasp.org

Expand Down
9 changes: 9 additions & 0 deletions cornucopia.owasp.org/.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
node_modules
npm-debug.log
build
.svelte-kit
coverage
.env
.env.*
.DS_Store
.vs
22 changes: 8 additions & 14 deletions cornucopia.owasp.org/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,17 @@ FROM node:iron-alpine3.21@sha256:957dbf2afb4f22d9e2b94b981e242cbb796965cd3d9cc02

WORKDIR /app

# Install dependencies
# V15.2: Copy the lockfile before install so dependency resolution is deterministic
# and Docker can safely cache the dependency layer.
COPY cornucopia.owasp.org/package.json ./
COPY cornucopia.owasp.org/pnpm-lock.yaml ./
# Install dependencies (lockfile copied for deterministic builds)
COPY package.json pnpm-lock.yaml ./
RUN npm install -g pnpm@v10.3.0 --save-exact
Comment thread
sydseter marked this conversation as resolved.
RUN pnpm install --frozen-lockfile

# Followed copilot suggestion 2: Copy source data AFTER dependency install
WORKDIR /source
COPY source .
# Copy source data needed for SvelteKit prerendering (card YAML files)
# The workflow copies the repo-root source/ directory into the build context
COPY source /source

WORKDIR /app
# Copy the frontend application code
COPY cornucopia.owasp.org .
COPY . .

Comment thread
sydseter marked this conversation as resolved.
# Build the application
ENV NODE_OPTIONS="--max-old-space-size=4096"
Expand All @@ -29,10 +25,8 @@ FROM nginx:alpine3.21@sha256:b471bb609adc83f73c2d95148cf1bd683408739a3c09c0afc66
COPY --from=builder /app/build /usr/share/nginx/html

# Copy custom Nginx configuration
COPY cornucopia.owasp.org/nginx.conf /etc/nginx/conf.d/default.conf
COPY nginx.conf /etc/nginx/conf.d/default.conf

EXPOSE 80

CMD ["nginx", "-g", "daemon off;"]

# Added a comment to push to repo webhook
CMD ["nginx", "-g", "daemon off;"]
Loading