Skip to content

Improve test coverage and fix code quality issues in convert.py#2872

Merged
sydseter merged 8 commits intoOWASP:masterfrom
theanand108:improve-convert-tests
Apr 24, 2026
Merged

Improve test coverage and fix code quality issues in convert.py#2872
sydseter merged 8 commits intoOWASP:masterfrom
theanand108:improve-convert-tests

Conversation

@theanand108
Copy link
Copy Markdown
Contributor

@theanand108 theanand108 commented Apr 24, 2026

Description

This PR improves test coverage and code quality for convert.py.

Changes include:

  • Increased test coverage (now ~87%)
  • Added tests for command argument handling and execution flow
  • Fixed flake8 issues (import order, trailing whitespace, formatting)
  • Applied black formatting
  • Ignored generated files (output.yaml)

No functional changes were made — only test quality and code style improvements.
Resolved or fixed issue: none

AI Tool Disclosure

  • My contribution does not include any AI-generated content
  • My contribution includes AI-generated content, as disclosed below:
    • AI Tools: ChatGPT
    • LLMs and versions: GPT-5.3
    • Prompts: Assisted with debugging tests, fixing lint issues, and improving code structure

Affirmation

  • My code follows the CONTRIBUTING.md guidelines

@sydseter sydseter merged commit 57dca9d into OWASP:master Apr 24, 2026
12 checks passed
@theanand108 theanand108 deleted the improve-convert-tests branch April 24, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants