test: increase coverage for convert.py to 95% with edge case tests#2880
Merged
sydseter merged 5 commits intoOWASP:masterfrom Apr 25, 2026
Merged
test: increase coverage for convert.py to 95% with edge case tests#2880sydseter merged 5 commits intoOWASP:masterfrom
sydseter merged 5 commits intoOWASP:masterfrom
Conversation
Collaborator
|
@theanand108 you need to format the files. |
Contributor
Author
|
Thanks for pointing that out. I’ve applied black formatting and pushed the changes. Please take another look. |
sydseter
approved these changes
Apr 25, 2026
Collaborator
|
@theanand108 Fantastic. Very nice. |
Contributor
Author
|
Thanks, Johan. Glad to help! I’ll continue working on improving coverage further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves test coverage for
convert.pyto meet the required 95% threshold by adding targeted edge-case tests and covering previously untested execution paths.Changes
Result
convert.pycoverage increased to ≥95%AI Disclosure
Some test scaffolding and edge-case ideas were assisted by AI tools, but all logic, validation, and debugging were reviewed and verified manually.
Affirmation
I confirm that I have followed the OWASP contribution guidelines and tested all changes locally.
Next Steps
Continue improving coverage for remaining modules (e.g.,
capec_map_enricher.py) to further strengthen test reliability.