fix: add missing backside tables to fallback lang ODT template#2899
Merged
sydseter merged 1 commit intoApr 29, 2026
Merged
Conversation
Ensure TableBackQR10 and TableBackQR11 are inserted in the correct position in the fallback _lang.odt template, matching the layout of all other language-specific templates. Closes OWASP#2133
Adarshkumar0509
requested review from
cw-owasp,
rewtd and
sydseter
as code owners
Contributor
Author
|
Hi @sydseter, I have added the missing backside tables (TableBackQR10 and TableBackQR11) to the fallback _lang.odt template in the correct position, matching the layout of all other language-specific templates. Please take a look when you have time! |
Contributor
Author
|
these failures are unrelated to my pr |
sydseter
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure TableBackQR10 and TableBackQR11 are inserted in the correct position in the fallback _lang.odt template, matching the layout of all other language-specific templates.
When an invalid language code is used (e.g. pt-br instead of pt_br), the converter falls back to the _lang.odt template. Previously thistemplate was missing the backside tables after the last card pages, causing incorrect layout in the generated documents.
Closes #2133
AI Tool Disclosure
[e.g. GitHub CoPilot, ChatGPT, JetBrains Junie etc.][e.g. GPT-4.1, Claude Haiku 4.5, Gemini 2.5 Pro etc.][Summarize the key prompts or instructions given to the AI tools]Affirmation