Add MASTG-TEST-0264, MASTG-TEST-0265, MASTG-DEMO-0038, MASTG-DEMO-0039#3246
Merged
Conversation
cpholguera
changed the title
Contributor
There was a problem hiding this comment.
Copilot reviewed 7 out of 11 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- demos/android/MASVS-RESILIENCE/MASTG-DEMO-0038/output.txt: Language not supported
- demos/android/MASVS-RESILIENCE/MASTG-DEMO-0038/run.sh: Language not supported
- demos/android/MASVS-RESILIENCE/MASTG-DEMO-0039/output.txt: Language not supported
- demos/android/MASVS-RESILIENCE/MASTG-DEMO-0039/run.sh: Language not supported
Comments suppressed due to low confidence (1)
rules/mastg-android-strictmode.yml:10
- [nitpick] The pattern 'StrictMode.setVmPolicy(...)' may be too generic and might not catch all variants of StrictMode usage (e.g., chained calls or alternative configurations such as penaltyLog). Consider expanding the pattern or adding an additional rule to ensure comprehensive detection.
- pattern: StrictMode.setVmPolicy(...)
…d-demos-38-and-39
titze
reviewed
Apr 7, 2025
Co-authored-by: titze <dennis.titze@guardsquare.com>
cpholguera
commented
May 25, 2025
cpholguera
commented
May 25, 2025
cpholguera
commented
May 25, 2025
cpholguera
commented
May 25, 2025
Collaborator
|
Changes / comments look good to me! |
titze
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two new demo tests for detecting
StrictModeusage in Android applications, using both dynamic and static analysis techniques.New demos
demos/android/MASVS-RESILIENCE/MASTG-DEMO-0038/MASTG-DEMO-0038.md: Added a demo for detectingStrictModeusage at runtime using Frida.demos/android/MASVS-RESILIENCE/MASTG-DEMO-0039/MASTG-DEMO-0039.md: Added a demo for detectingStrictModepenalty log usage in the codebase using Semgrep.New Tests
tests-beta/android/MASVS-RESILIENCE/MASTG-TEST-0264.md: Added documentation for a dynamic test to check runtime use ofStrictModeAPIs.tests-beta/android/MASVS-RESILIENCE/MASTG-TEST-0265.md: Added documentation for a static test to identify references toStrictModeAPIs.