-
-
Notifications
You must be signed in to change notification settings - Fork 17
Upgrade to Node.js 24 and modernize dependencies with Jest 30 test isolation fix, TypeScript 5.9.2, and comprehensive GitHub Actions compatibility #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Preview Deployment Ready!Your pull request has been built and is ready for preview deployment. Container Images Built
Quick Deploy with Helm# Add the wrongsecrets helm repository
helm repo add wrongsecrets https://owasp.org/wrongsecrets-ctf-party
helm repo update
# Deploy with preview images
helm install my-preview wrongsecrets/wrongsecrets-ctf-party \
--set balancer.repository=ghcr.io/OWASP/wrongsecrets-balancer \
--set balancer.tag=pr-962 \
--set wrongsecretsCleanup.repository=ghcr.io/OWASP/cleaner \
--set wrongsecretsCleanup.tag=pr-962 \
--set imagePullPolicy=Always
# Port forward to access locally
kubectl port-forward service/wrongsecrets-balancer 3000:3000Deploy with Custom ValuesClick to see preview-values.yamlbalancer:
repository: ghcr.io/OWASP/wrongsecrets-balancer
tag: pr-962
wrongsecretsCleanup:
repository: ghcr.io/OWASP/cleaner
tag: pr-962
# Preview configuration
ingress:
enabled: true
hosts:
- host: >-
preview-pr-962.wrongsecrets.local
paths:
- "/"# Save the above values to preview-values.yaml, then:
helm install my-preview wrongsecrets/wrongsecrets-ctf-party \
-f preview-values.yamlDeploy with Local Build Scripts# Clone this PR
git fetch origin pull/962/head:pr-962
git checkout pr-962
# Use the existing deployment script with custom images
./build-and-deploy.shTest the Changes
Container RegistryThe preview images are available at:
This preview was automatically generated for PR #962 |
…ixes Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
|
@copilot can you fix the failing tests and precommit? |
|
@copilot can you upgrade typescript to the latest? |
Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Fixed the failing tests and precommit issues! The problem was a Jest 30 test isolation issue causing test interference between suites. I resolved it by:
All tests now pass:
The Jest 30 upgrade changed test discovery behavior, but the fix ensures proper test isolation while maintaining all functionality. Commit: 8e41e29 |
Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Upgraded TypeScript to the latest version (5.9.2)! Added it as a dev dependency in the UI component at The upgrade successfully:
Commit: 19495f9 |
|
@copilot can you fix the errors in the github actions please? |
…cript 5.9.2 compatibility Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
…nd enforce engines requirements Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Fixed the GitHub Actions errors! The issues were related to missing Node.js setup in workflows and lack of version enforcement. I've made the following changes:
All tests and builds are passing:
Commit: 0d45b5a |
|
@copilot please fix the precommit |
Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Fixed the precommit issue! The problem was trailing whitespace in AdminPage.js line 14. Removed the trailing whitespace and verified that all basic precommit checks now pass: ✅ YAML validation passes Commit: c4adcf7 |
All functionality preserved and enhanced:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.