Skip to content

Fix menu item counter#10

Closed
dx-dmueller wants to merge 2 commits into
OXID-eSales:b-7.5.xfrom
dx-dmueller:b-7.4.x
Closed

Fix menu item counter#10
dx-dmueller wants to merge 2 commits into
OXID-eSales:b-7.5.xfrom
dx-dmueller:b-7.4.x

Conversation

@dx-dmueller
Copy link
Copy Markdown
Contributor

Project-related menu items in the admin were created with incorrect class names because the menu index was reset to 0 within the loop.

dx-dmueller and others added 2 commits July 3, 2025 15:19
…lass names because the menu index was reset to 0 within the loop.
Project-related menu items in the admin were created with incorrect class names because the menu index was reset to 0 within the loop.
@Sieg
Copy link
Copy Markdown
Member

Sieg commented Aug 8, 2025

Hey @dx-dmueller, could you please provide some example which is causing the issue. I believe it may be not everything, as according to your change, there should be an issue in "{% set menuIndex = menuIndex + 1 %}" also, which is in the deeper foreach as well, but probably should be moved out also.

@dx-dmueller
Copy link
Copy Markdown
Contributor Author

Hi @Sieg

my PR refers and fixes https://bugs.oxid-esales.com/view.php?id=7812 and https://bugs.oxid-esales.com/view.php?id=7741

To test it you can simply simulate proejct related Menuentries under a vendor specific menulist with adding following code to admin menu.xml ( right under OXID standard :

<OXMENU id="TEST">
    <MAINMENU id="test1">
        <SUBMENU id="test1-1" cl="test1-1"/>
        <SUBMENU id="test1-2" cl="test1-2"/>
    </MAINMENU>
    <MAINMENU id="test2">
        <SUBMENU id="test2-1" cl="test2-1"/>
        <SUBMENU id="test2-2" cl="test2-2"/>
        <SUBMENU id="test2-3" cl="test2-3"/>
    </MAINMENU>
</OXMENU>

You will then get following result and the test menu entries do not close after choosing any other menu.

image

This behaviour is different to <= OXID 6

@Sieg Sieg changed the base branch from b-8.0.x to b-7.5.x November 12, 2025 11:27
@Sieg
Copy link
Copy Markdown
Member

Sieg commented Nov 20, 2025

Hey @dx-dmueller, thanks for the pull request. Merged the fix with some other small improvements to b-7.5.x here - 9ce8c19

@Sieg Sieg closed this Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants