Skip to content

Conversation

@Laksen
Copy link
Contributor

@Laksen Laksen commented Mar 19, 2024

No description provided.

@gcarreno
Copy link
Collaborator

gcarreno commented Mar 20, 2024

Hey @Laksen,

You missed 2 important things:

  1. The top title on the README must be first and fast name( e.g. Gustavo Carreno )
  2. The folder should follow first name initial and last name( e.g. gcarreno )

If you feel that this exposes your privacy, you can always use some fictional character's name like I mention on the README.

After looking at your code and the usage, could you give an example of a normal call on the README?
I understand the thread param, but I have no context for the chunks.
Could you, please, also write in the README what are the ranges accepted for:

  • threads
  • chunks

And please have code to guard against negative values, or even 0 if that is not possible.

Cheers,
Gus

@Laksen
Copy link
Contributor Author

Laksen commented Mar 20, 2024

@gcarreno

Should be fixed now. Changed parameter naming. Also reformatted

@gcarreno
Copy link
Collaborator

Hey Lurendrejer(@Laksen),

Looks good to go!!

I especially like the detail of having different exit values for the error in the params, that's quite a nice touch!!

Cheers,
Gus

@gcarreno gcarreno merged commit 11c6ff6 into ObjectPascal-Community:main Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants