Skip to content

initial version 1.0#77

Merged
gcarreno merged 2 commits intoObjectPascal-Community:mainfrom
hg747:main
Apr 2, 2024
Merged

initial version 1.0#77
gcarreno merged 2 commits intoObjectPascal-Community:mainfrom
hg747:main

Conversation

@hg747
Copy link
Copy Markdown
Contributor

@hg747 hg747 commented Apr 2, 2024

This is my initial version 1.0

@gcarreno
Copy link
Copy Markdown
Collaborator

gcarreno commented Apr 2, 2024

Hey Hartmut(@hg747),

I'm sooooo happy!!! I'm so happy that I'm, literally, jumping up and down with joy inside the vast emptiness that is my brain 😄

I'm really happy that you were able to sort out this GitHub thing, I really am!! 🫂 ❤️

Just one ask: The first line of your README.md should be as follows:

# Hartmut Grosser

You can just add another commit to this branch and GitHub will bundle it up.
If you find that difficult, gimme a shout and I'll do it myself.

Again, very, very over the Moon for your entry!!!!

Cheers,
Gus

@gcarreno
Copy link
Copy Markdown
Collaborator

gcarreno commented Apr 2, 2024

Awesome sauce!!
Merging!!

@gcarreno gcarreno merged commit 559e20a into ObjectPascal-Community:main Apr 2, 2024
@hg747
Copy link
Copy Markdown
Contributor Author

hg747 commented Apr 2, 2024

I updated my readme.md and was able to upload it to my repository in https://github.com/hg747/1brc-ObjectPascal

Then I tried a new pull request for this but I am not sure if I did it correctly. Can you please check? Thanks.

@gcarreno
Copy link
Copy Markdown
Collaborator

gcarreno commented Apr 2, 2024

Hey Hartmut(@hg747),

When you have an open Pull Request(PR), you just have to upload(git push) subsequent commits.
Then GitHub will automatically add up, or bundle up, all those commits.

This to say that I got that last commit and all is perfect.

Cheers,
Gus

@hg747
Copy link
Copy Markdown
Contributor Author

hg747 commented Apr 2, 2024

Great. Thanks for clarification. This all is bloody new to me.
Did you see in the readme.md that I ask you to run my program 3 times with different buffer sizes (if you have time)?

@gcarreno
Copy link
Copy Markdown
Collaborator

gcarreno commented Apr 2, 2024

Hey Hartmut(@hg747),

Great. Thanks for clarification. This all is bloody new to me.

You're more than welcome!!
And yes, I admire the effort you're putting in to this with all being so new to you. I really do!!

Did you see in the readme.md that I ask you to run my program 3 times with different buffer sizes (if you have time)?

Here you go:

$ time ./bin/hgrosser /tmp/measurements-1_000_000_000.txt 128
{..}
real	1m12.124s
user	1m10.476s
sys	0m1.584s
$ time ./bin/hgrosser /tmp/measurements-1_000_000_000.txt 192
{..}
real	1m13.402s
user	1m12.008s
sys	0m1.332s
$ time ./bin/hgrosser /tmp/measurements-1_000_000_000.txt 192
{..}
real	1m14.932s
user	1m13.311s
sys	0m1.568s

Looks like the default 128 has the best time, so keeping that in the automation!!

Cheers,
Gus

@hg747
Copy link
Copy Markdown
Contributor Author

hg747 commented Apr 2, 2024

Thanks a lot. You are very friendly. On my (old) computer, '128' had the best result too, so we have the same behaviour on your fast machine.

@gcarreno
Copy link
Copy Markdown
Collaborator

gcarreno commented Apr 2, 2024

Hey Hartmut(@hg747),

Thanks a lot. You are very friendly.

You're more than welcome!!
And thank you for the kind compliment!! 🫂 ❤️

On my (old) computer, '128' had the best result too, so we have the same behaviour on your fast machine.

Indeed!!

Cheers,
Gus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants