Skip to content

ghatem single-threaded entry#79

Merged
gcarreno merged 6 commits intoObjectPascal-Community:mainfrom
georges-hatem:ghatem
Apr 3, 2024
Merged

ghatem single-threaded entry#79
gcarreno merged 6 commits intoObjectPascal-Community:mainfrom
georges-hatem:ghatem

Conversation

@georges-hatem
Copy link
Copy Markdown
Contributor

No description provided.

@gcarreno
Copy link
Copy Markdown
Collaborator

gcarreno commented Apr 3, 2024

Hey Georges(@georges-hatem),

There's still that baseline.output file that you let slip in.

Apart from that, the PR is good. Even with the correction to the param parsing. Which is very welcomed!!

Cheers,
Gus

@georges-hatem
Copy link
Copy Markdown
Contributor Author

@gcarreno file removed. I also tried to alter attributes in my subfolder so as to see the file diff as text (currently github shows it as binary somehow).
it will still display as text at your end, just not diffable

@gcarreno
Copy link
Copy Markdown
Collaborator

gcarreno commented Apr 3, 2024

Hey Georges(@georges-hatem),

Do you feel that it's now good to merge?

Cheers,
Gus

@georges-hatem
Copy link
Copy Markdown
Contributor Author

Yes, it's ready

@gcarreno gcarreno merged commit 0d9fd37 into ObjectPascal-Community:main Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants