Skip to content

Conversation

@KaloyanTanev
Copy link
Collaborator

Simple refactoring and grouping of the functions in the charon test files. They grew quite a lot and thought some grouping would help. There is nothing new introduced (except comments), despite git's assumption of many additions and deletions.

category: refactor
ticket: none

@KaloyanTanev KaloyanTanev requested a review from pinebit November 11, 2024 17:33
@KaloyanTanev KaloyanTanev self-assigned this Nov 11, 2024
@github-actions github-actions bot added the branch-invalid PR raised against invalid branch. Not a main or release branch. label Nov 11, 2024
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 42.80303% with 302 lines in your changes missing coverage. Please review.

Project coverage is 57.73%. Comparing base (245f821) to head (27421c0).
Report is 1 commits behind head on kalo/test-command-ux.

Files with missing lines Patch % Lines
cmd/testpeers.go 61.31% 99 Missing and 19 partials ⚠️
cmd/testperformance.go 21.67% 101 Missing and 11 partials ⚠️
cmd/testbeacon.go 4.44% 43 Missing ⚠️
cmd/testvalidator.go 0.00% 19 Missing ⚠️
cmd/testmev.go 37.50% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           kalo/test-command-ux    #3377      +/-   ##
========================================================
- Coverage                 57.78%   57.73%   -0.05%     
========================================================
  Files                       217      217              
  Lines                     31619    31619              
========================================================
- Hits                      18270    18256      -14     
- Misses                    11467    11481      +14     
  Partials                   1882     1882              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaloyanTanev KaloyanTanev merged commit c806e95 into kalo/test-command-ux Nov 12, 2024
@KaloyanTanev KaloyanTanev deleted the kalo/group-test-functions branch November 12, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch-invalid PR raised against invalid branch. Not a main or release branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants