cmd: test command flags update #3390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3390 +/- ##
==========================================
+ Coverage 57.24% 57.35% +0.11%
==========================================
Files 217 217
Lines 32028 31978 -50
==========================================
+ Hits 18333 18342 +9
+ Misses 11799 11745 -54
+ Partials 1896 1891 -5 ☔ View full report in Codecov by Sentry. |
|
pinebit
reviewed
Nov 26, 2024
pinebit
approved these changes
Nov 26, 2024
KaloyanTanev
added
the
merge when ready
KaloyanTanev
added a commit
that referenced
this pull request
Nov 26, 2024
After QA testing and review by Oisin, some changes were made. - Rename `--cluster-lock-file-path` to `--lock-file` and `--cluster-definition-file-path` to `--definition-file` in test peers command. This is to be aligned with the rest of the CLI. - Allow passing of cluster definition by URL to `--definition-file` flag. - Remove [REQUIRED] from the MEV test `--beacon-node-endpoint` flag description, as this flag is required only if `--load-test` is enabled. - Do single MEV block creation test, to which users can specify number of blocks to smoothen the result. Previously we had 2 test, one with single block and second with multiple (by default 3). Now it is only the second test with a default of 1. - Rename the `--load-test-blocks` flag in MEV test to `--number-of-payloads`. - Round the measurements - > 1s to 2 digits after the decimal, < 1s to whole number. - Delete the fio command created test file. - Add a missed return statement. - Bring back the test command to alpha state 😔. category: feature ticket: none
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After QA testing and review by Oisin, some changes were made.
--cluster-lock-file-pathto--lock-fileand--cluster-definition-file-pathto--definition-filein test peers command. This is to be aligned with the rest of the CLI.--definition-fileflag.--beacon-node-endpointflag description, as this flag is required only if--load-testis enabled.--load-test-blocksflag in MEV test to--number-of-payloads.category: feature
ticket: none