Skip to content

Comments

*: track indices for which duties were fetched in cache#4333

Merged
obol-bulldozer[bot] merged 2 commits intomainfrom
kalo/lighthouse-submit-attestations-bugfix
Feb 22, 2026
Merged

*: track indices for which duties were fetched in cache#4333
obol-bulldozer[bot] merged 2 commits intomainfrom
kalo/lighthouse-submit-attestations-bugfix

Conversation

@KaloyanTanev
Copy link
Collaborator

Save indices for which the request was done. This helps with proposal duties caching, as for a request of N indices only a subset (if any) are returned. However, if we do not store the indices for which the cache was created, we cannot know if the initial request was for all indices or only for 1.

category: bug
ticket: #4009

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

❌ Patch coverage is 21.00840% with 94 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.34%. Comparing base (4070c56) to head (36e174c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
app/eth2wrap/cache.go 20.33% 93 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4333      +/-   ##
==========================================
- Coverage   56.39%   56.34%   -0.06%     
==========================================
  Files         237      237              
  Lines       31660    31696      +36     
==========================================
+ Hits        17856    17858       +2     
- Misses      11517    11548      +31     
- Partials     2287     2290       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Feb 22, 2026
@obol-bulldozer obol-bulldozer bot merged commit 359d85c into main Feb 22, 2026
11 of 12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/lighthouse-submit-attestations-bugfix branch February 22, 2026 17:26
KaloyanTanev added a commit that referenced this pull request Feb 22, 2026
Save indices for which the request was done. This helps with proposal duties caching, as for a request of N indices only a subset (if any) are returned. However, if we do not store the indices for which the cache was created, we cannot know if the initial request was for all indices or only for 1.

category: bug
ticket: #4009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants