Skip to content

core: abundant QBFT logging#4380

Merged
obol-bulldozer[bot] merged 3 commits intomainfrom
kalo/more-qbft-logging
Mar 11, 2026
Merged

core: abundant QBFT logging#4380
obol-bulldozer[bot] merged 3 commits intomainfrom
kalo/more-qbft-logging

Conversation

@KaloyanTanev
Copy link
Collaborator

Abundant QBFT debug logging as an attempt to diagnose failing attestations.

category: misc
ticket: none

@KaloyanTanev KaloyanTanev force-pushed the kalo/more-qbft-logging branch from 3e8072f to 1d0490c Compare March 11, 2026 09:23
@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Mar 11, 2026
@sonarqubecloud
Copy link

@obol-bulldozer obol-bulldozer bot merged commit 3a2eed5 into main Mar 11, 2026
10 of 11 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/more-qbft-logging branch March 11, 2026 09:44
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.61%. Comparing base (0df5c72) to head (0829989).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
core/qbft/qbft.go 95.45% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4380      +/-   ##
==========================================
+ Coverage   56.35%   56.61%   +0.26%     
==========================================
  Files         237      237              
  Lines       31687    31636      -51     
==========================================
+ Hits        17858    17912      +54     
+ Misses      11539    11440      -99     
+ Partials     2290     2284       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KaloyanTanev added a commit that referenced this pull request Mar 11, 2026
Abundant QBFT debug logging as an attempt to diagnose failing attestations.

category: misc
ticket: none
KaloyanTanev added a commit that referenced this pull request Mar 11, 2026
* core: abundant QBFT logging (#4380)

Abundant QBFT debug logging as an attempt to diagnose failing attestations.

category: misc
ticket: none

* Remove empty file
pinebit added a commit that referenced this pull request Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants