Skip to content

app/*: report EL version metric#4434

Merged
KaloyanTanev merged 6 commits intomainfrom
kalo/report-el-version
Apr 1, 2026
Merged

app/*: report EL version metric#4434
KaloyanTanev merged 6 commits intomainfrom
kalo/report-el-version

Conversation

@KaloyanTanev
Copy link
Copy Markdown
Collaborator

Report EL version if the flag for EL is set.

category: feature
ticket: #4429

@KaloyanTanev KaloyanTanev requested review from Copilot and pinebit April 1, 2026 09:29
@KaloyanTanev KaloyanTanev self-assigned this Apr 1, 2026
@KaloyanTanev KaloyanTanev changed the title Report EL version metric app/*: report EL version metric Apr 1, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds execution-layer (EL) client version reporting to Charon’s Prometheus metrics so operators can observe the configured EL implementation/version (and get compatibility warnings) alongside existing beacon node version reporting.

Changes:

  • Add app_execution_layer_version{version=...} gauge and periodically populate it from web3_clientVersion.
  • Extend eth1wrap.EthClientRunner with ClientVersion and implement it (noop + real client + mocks).
  • Add EL version parsing/min-version checks with warning logs for unsupported/too-old/incompatible EL versions.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
app/monitoringapi.go Adds EL version metric collection alongside beacon node version collection.
app/metrics.go Introduces executionEngineVersionGauge metric definition.
app/eth1wrap/version.go Adds EL web3_clientVersion parsing and compatibility checks/warnings.
app/eth1wrap/runner.go Implements ClientVersion RPC call (and noop behavior).
app/eth1wrap/mocks/eth_client_runner.go Updates generated mock to include ClientVersion.
app/eth1wrap/interface.go Extends EthClientRunner interface with ClientVersion.
app/app.go Wires eth1Cl into monitoring API so EL version can be queried.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

KaloyanTanev and others added 4 commits April 1, 2026 17:52
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: kalo <24719519+KaloyanTanev@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@KaloyanTanev KaloyanTanev enabled auto-merge (squash) April 1, 2026 16:43
@KaloyanTanev KaloyanTanev force-pushed the kalo/report-el-version branch from 6ceeabe to d9e3a68 Compare April 1, 2026 20:52
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 1, 2026

@KaloyanTanev KaloyanTanev merged commit 5a8f76d into main Apr 1, 2026
10 of 11 checks passed
@KaloyanTanev KaloyanTanev deleted the kalo/report-el-version branch April 1, 2026 21:02
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 19.35484% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.51%. Comparing base (c89a7ee) to head (d9e3a68).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
app/eth1wrap/version.go 7.89% 34 Missing and 1 partial ⚠️
app/eth1wrap/runner.go 0.00% 12 Missing ⚠️
app/app.go 0.00% 2 Missing ⚠️
app/monitoringapi.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4434      +/-   ##
==========================================
+ Coverage   56.47%   56.51%   +0.04%     
==========================================
  Files         244      245       +1     
  Lines       32550    32608      +58     
==========================================
+ Hits        18381    18428      +47     
- Misses      11820    11834      +14     
+ Partials     2349     2346       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants