Conversation
There was a problem hiding this comment.
Pull request overview
Adds execution-layer (EL) client version reporting to Charon’s Prometheus metrics so operators can observe the configured EL implementation/version (and get compatibility warnings) alongside existing beacon node version reporting.
Changes:
- Add
app_execution_layer_version{version=...}gauge and periodically populate it fromweb3_clientVersion. - Extend
eth1wrap.EthClientRunnerwithClientVersionand implement it (noop + real client + mocks). - Add EL version parsing/min-version checks with warning logs for unsupported/too-old/incompatible EL versions.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/monitoringapi.go | Adds EL version metric collection alongside beacon node version collection. |
| app/metrics.go | Introduces executionEngineVersionGauge metric definition. |
| app/eth1wrap/version.go | Adds EL web3_clientVersion parsing and compatibility checks/warnings. |
| app/eth1wrap/runner.go | Implements ClientVersion RPC call (and noop behavior). |
| app/eth1wrap/mocks/eth_client_runner.go | Updates generated mock to include ClientVersion. |
| app/eth1wrap/interface.go | Extends EthClientRunner interface with ClientVersion. |
| app/app.go | Wires eth1Cl into monitoring API so EL version can be queried. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: kalo <24719519+KaloyanTanev@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6ceeabe to
d9e3a68
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4434 +/- ##
==========================================
+ Coverage 56.47% 56.51% +0.04%
==========================================
Files 244 245 +1
Lines 32550 32608 +58
==========================================
+ Hits 18381 18428 +47
- Misses 11820 11834 +14
+ Partials 2349 2346 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|



Report EL version if the flag for EL is set.
category: feature
ticket: #4429