*: improve slack notification on Kurtosis#4508
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR improves the Kurtosis smoke test Slack notification by including a concise, Slack-friendly summary of which clusters had firing alerts (and whether metrics coverage looks incomplete).
Changes:
- Add helper logic to summarize “failed” clusters (from firing alerts + optional metrics coverage signal) and write it to an output file.
- Extend the Kurtosis smoke test workflow to persist that summary as an artifact and embed it into the Slack failure message.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/debug/kurtosis_alerts.py | Adds --failed-clusters-out support and generates a Slack-friendly cluster failure summary file. |
| .github/workflows/kurtosis-smoke-test.yml | Calls the new flag, uploads failed_clusters.txt, and injects a formatted block into the Slack failure notification. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4508 +/- ##
==========================================
+ Coverage 57.11% 57.14% +0.03%
==========================================
Files 245 245
Lines 32920 32939 +19
==========================================
+ Hits 18801 18824 +23
+ Misses 11752 11748 -4
Partials 2367 2367 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Report which clusters failed Kurtosis tests in Slack
category: feature
ticket: none