Conversation
bussyjd
added a commit
that referenced
this pull request
Apr 7, 2026
…recision Address review findings from #310 merge: - fixVolumeOwnership: log errors instead of silently swallowing them so failed chown is visible in CLI output for debugging - fixVolumeOwnership: reject paths outside DataDir (../ traversal guard) to prevent docker exec targeting unexpected node paths - docker-publish-x402: remove broken matrix outputs (both pointed to last-finishing job), scan by SHA tag instead of :latest for deterministic Trivy results matching the exact build - obolup.sh: warn before restarting Ollama service, only restart if already active to avoid disrupting running inference
4 tasks
bussyjd
added a commit
that referenced
this pull request
Apr 7, 2026
…vy scan precision Address review findings from #310 merge: - fixVolumeOwnership: use ui.Warnf (variadic optional) instead of silently swallowing errors, aligned with the codebase's UI logging pattern (54 u.Warn/Success calls vs 0 log.Printf in this file) - fixVolumeOwnership: reject paths outside DataDir (../ traversal guard) to prevent docker exec targeting unexpected node paths - docker-publish-x402: remove broken matrix outputs (both pointed to last-finishing job), scan by SHA tag instead of :latest for deterministic Trivy results matching the exact build - obolup.sh: warn before restarting Ollama service, only restart if already active to avoid disrupting running inference
bussyjd
added a commit
that referenced
this pull request
Apr 7, 2026
… Trivy precision Address review findings from #310 merge: - fixVolumeOwnership: thread *ui.UI through the full call chain (ensureWallet → GenerateWallet → provisionKeystoreToVolume → fixVolumeOwnership) so chown failures surface via u.Warnf, uniform with the rest of the codebase (zero log.Printf in openclaw package) - fixVolumeOwnership: reject paths outside DataDir (../ traversal guard) to prevent docker exec targeting unexpected node paths - docker-publish-x402: remove broken matrix outputs (both pointed to last-finishing job), scan by SHA tag instead of :latest for deterministic Trivy results matching the exact build - obolup.sh: warn before restarting Ollama service, only restart if already active to avoid disrupting running inference
OisinKyne
pushed a commit
that referenced
this pull request
Apr 7, 2026
…ion (#311) * fix: harden PR #310 — thread ui.UI for chown errors, path validation, Trivy precision Address review findings from #310 merge: - fixVolumeOwnership: thread *ui.UI through the full call chain (ensureWallet → GenerateWallet → provisionKeystoreToVolume → fixVolumeOwnership) so chown failures surface via u.Warnf, uniform with the rest of the codebase (zero log.Printf in openclaw package) - fixVolumeOwnership: reject paths outside DataDir (../ traversal guard) to prevent docker exec targeting unexpected node paths - docker-publish-x402: remove broken matrix outputs (both pointed to last-finishing job), scan by SHA tag instead of :latest for deterministic Trivy results matching the exact build - obolup.sh: warn before restarting Ollama service, only restart if already active to avoid disrupting running inference * refactor: migrate fmt.Print* output to ui.UI in CLI commands Route all CLI output through the ui.UI layer instead of raw fmt calls. This ensures all output respects --verbose, --quiet, and future --output json mode (Phase 1C of cli-agent-readiness plan). - sell.go: 77 fmt.Print* calls → u.Infof/Warnf/Successf/Printf - network.go: 28 fmt.Print* calls → u.Infof/Warnf/Successf/Printf - model.go: 17 fmt.Print* calls → u.Infof/Warnf/Successf/Printf Thread u *ui.UI into standalone helpers that previously used fmt directly: removePricingRoute, runInferenceGateway, registerSponsored, registerDirectViaSigner, registerDirectWithKey. --------- Co-authored-by: bussyjd <bussyjd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.