fix: only install light client for selected network #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the obolup script to only install the light client for the selected network instead of installing all three networks (mainnet, hoodi, sepolia) every time.
Problem Solved
Previously, when running
./obolup --network hoodi, the script would install light clients for ALL networks:This caused:
--networkflag didn't fully control what was deployedSolution
Changed the script to only install the light client for the selected network using the
$__networkvariable.Before:
log_info "Installing the Obol Stack Ethereum light clients..." ensure helm upgrade ... --install l1-light-client-mainnet obol/helios -f ../values/mainnet/helios.yaml ensure helm upgrade ... --install l1-light-client-hoodi obol/helios -f ../values/hoodi/helios.yaml ensure helm upgrade ... --install l1-light-client-sepolia obol/helios -f ../values/sepolia/helios.yamlAfter:
Impact
--networkflag and what gets deployedkubectl get pods -n l1outputTesting
Breaking Changes
None - this makes the behavior match what users expect from the
--networkflag.