fix: simplify Hermes recreation lifecycle#413
Merged
Conversation
OisinKyne
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes the remaining actionable parts of #411 with a narrower fix:
nousresearch/hermes-agent:v2026.4.30/opt/hermes/.venv/bin/hermesand required extras before the gateway startswallet-metadataConfigMap during wallet restore before restarting remote-signerobol agent wallet backup/restorehelp text runtime-neutralWhy
PR #411 contained several useful changes, but most are already on
mainand the remaining branch is conflicted. The highest-value unresolved fix is the Hermes recreation path: the pod should not mutate a PVC by cloning a git repo and building a venv on every cold start. That made recreation fragile and left read-only git/venv artifacts in volumes.This PR keeps the simple image-based runtime contract while preserving safety: if the published image ever lacks the binary or extras we need, the init container fails clearly instead of booting a broken agent.
Validation
git diff --checkgo test ./cmd/obol ./internal/hermes ./internal/stack -count=1go test ./... -count=1docker manifest inspect nousresearch/hermes-agent:v2026.4.30docker run --rm --entrypoint sh nousresearch/hermes-agent:v2026.4.30 -ec 'test -x /opt/hermes/.venv/bin/hermes && /opt/hermes/.venv/bin/python3 -c "import fastapi, uvicorn, telegram, mcp, ptyprocess, simple_term_menu, googleapiclient"'Notes
I intentionally did not bring over #411's
litellm-configdelete/recreate behavior.mainalready has the managed-fields mitigation, and replacing it with ConfigMap deletion should be a separate change only if we can reproduce thatmainstill fails stack recreation.