Update with fixes#431
Merged
Merged
Conversation
bussyjd
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verifier crashloop fix (the blocker)
now treats os.ErrNotExist as a soft
success — returns a defaulted
PricingConfig (chain base, default
facilitator, zero routes) and logs a
friendly explanation. Other read errors
(permission denied, IO failures) still
surface so genuinely broken deployments
fail loudly. defaultPricingConfig()
helper introduced.
TestLoadConfig_FileNotFound_ReturnsDefau
ltsWithoutError (the rc10 reproducer)
and TestLoadConfig_UnreadableFile_StillE
rrors (permission-denied path still
rejects). Skips the latter under root.
--config /tmp/does-not-exist.yaml
--listen :18402 --watch=false boots
cleanly, logs the friendly message,
/healthz → 200, /verify → 200 for an
unmatched URI. The new HTML 402 path is
unblocked once the new image rolls.
setMetadata revert decoder (the partial
fix)
decodeRevertReason(err) and
wrapTransactError(prefix, err). Decodes
the three Solidity revert shapes the
node returns on the JSON-RPC data field:
→ the literal Solidity message.
→ mapped to a human label via
panicReason() (overflow, div-by-zero,
OOB, etc.).
as custom error 0x so an
operator can grep the contract source.
SetMetadata, SetMetadataWithOpts,
SetAgentURI now wrap their Transact
error with the decoder. The original
error chain stays intact for
errors.Is/As.
unit tests covering Error(string),
Panic(uint256), unknown selector, and
the no-data fast-paths.
extended the mock RPC to attach data on
JSON-RPC error envelopes via a new
rpcMockDataError type. Two new
SetMetadata tests assert the decoded
reason / selector show up in the wrapped
CLI error.
What this means for the rc10 reproducer:
next time someone runs obol sell
register twice in a row and hits the
revert, the CLI message will contain
either the Solidity revert("…") text or
custom error 0x — enough for
engineering to grep the registry
contract and identify the actual
rejection condition (probably
MetadataAlreadySet or a wallet-policy
check, per the report). Doesn't fix the
root cause, but turns the opaque error
into something diagnosable in one rerun
rather than a chain-trace expedition.