fix(sell): accept --yes / -y as aliases for --force on sell delete#472
Conversation
`obol sell delete <name> -n <ns>` only accepted `--force` / `-f` to skip the confirmation prompt; the conventional non-interactive flags `--yes` and `-y` were rejected with "Incorrect Usage: flag provided but not defined: -yes". This bit a scripted teardown on spark2 today. Add them as aliases on the existing `--force` BoolFlag so the same runtime path is taken — behaviour is unchanged, only the surface grows. Help text is updated to advertise all three. Scoped intentionally to `sell delete` because that is what surfaced. Other commands (`stack purge`, `agent delete`, `app delete`, `network remove`) also use `--force` without `-y` and would benefit from the same treatment in a follow-up. Test plan: - `obol sell delete --help` now lists `--force, -f, -y, --yes`. - `go build ./...` clean.
SummaryWhat changed: Why it matters: scripted teardowns and operators muscle-memoried on Risk level: low Commit under test: tip of Base branch: main Scope
ValidationCI checks:
Unit tests: Integration tests: Flow tests:
Release smoke: Live Chain Evidencen/a — Runtime EvidenceQA environment:
Images: n/a Kubernetes / stack:
Model and routing: n/a Artifacts and logs:
Demo readiness:
Review NotesKnown gaps:
Follow-ups:
Reviewer focus:
|
Summary
obol sell delete <name> -n <ns>only accepted--force/-fto skip the confirmation prompt. The conventional non-interactive flags--yesand-ywere rejected outright:This blocks scripted teardowns and surprises operators muscle-memoried on
-y. Surfaced on spark2 today while tearing down an offer between two flow runs.Fix: add
y,yesas aliases on the existing--forceBoolFlag. Same runtime path, just more accepted surface.Scope
Intentionally narrow to
sell deletebecause that is what surfaced. Several other places also gate destructive commands on--forcewithout-y:obol stack purge -fobol agent delete --forceobol app delete --forceobol network remove --forceA consistency pass across all of them is a reasonable follow-up; I left it out here to keep the PR scoped to a single confirmed regression.
Test plan
obol sell delete --helpnow lists--force, -f, -y, --yes.go build ./...clean.obol sell delete aeon -n llm --yesand-yboth run without the "flag not defined" error.Full report (PR template) added as the first comment.