refactor(flows): collapse per-flow env injection in release-smoke runner#476
Closed
bussyjd wants to merge 1 commit into
Closed
refactor(flows): collapse per-flow env injection in release-smoke runner#476bussyjd wants to merge 1 commit into
bussyjd wants to merge 1 commit into
Conversation
run_flow now accepts optional env_name/env_value args, replacing three
hand-coded `if name == flow-XX` branches. env "VAR=val" bash $flow is
semantically identical to the inline `VAR=val bash $flow` form for
child-only export. Validated end-to-end on spark1: flow-11/13/14
each populated their FLOW{11,13,14}_ARTIFACT_DIR receipt subdirs.
Also:
- Defensive ${var:-0} on FAIL/SKIP grep counters so a missing log
can't crash the [ "$var" -eq 0 ] arithmetic under set -e.
- Inlined the one-shot cleanup_default_stack_before_dual helper.
- Brief comment on why flow-10 sits between flow-07 and flow-08
(flow-08 header explicitly requires flow-10's Anvil facilitator).
bussyjd
force-pushed
the
refactor/release-smoke-env-injection
branch
from
7a61b11 to
12f685c
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_flownow accepts optionalenv_name env_valueargs, replacing three hand-codedif name == flow-XXbranches.env "VAR=val" bash \$flowis semantically identical to inlineVAR=val bash \$flowfor child-only export — validated end-to-end on spark1 whereflow-11-receipts/,flow-13-receipts/, andflow-14-receipts/all got populated with the expected on-chain JSON receipts.${var:-0}on FAIL/SKIP grep counters so a missing log can't crash the[ "$var" -eq 0 ]arithmetic underset -e.cleanup_default_stack_before_dualhelper.Test plan
bash -n flows/release-smoke.shclean:-0defaults (run on spark1, bash 5.2.21)flows/release-smoke.shrun on spark1 withRELEASE_SMOKE_INCLUDE_OBOL=true RELEASE_SMOKE_INCLUDE_OBOL_FORK=true— receipt dirs populated by all three of flow-11/13/14