chore: harden secret leak prevention#495
Merged
Merged
Conversation
- Add *.txt to .gitignore (with NOTES.txt exception for Helm charts) to prevent accidental commits of log/debug output files - Add custom gitleaks rules for HTTP Basic Auth and Authorization header patterns in log output - Add gitleaks CI workflow to enforce scanning on PRs and pushes Prompted by an incident where a Charon log file containing a Basic Auth header was accidentally committed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bussyjd
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*.txtto.gitignore(with!**/templates/NOTES.txtexception for Helm charts) to prevent accidental commits of log/debug output filesAuthorizationheader patterns commonly found in Charon log outputgitleaks.yml) to enforce secret scanning on PRs and pushes tomainContext
Gitleaks was already configured in
.pre-commit-config.yaml(good), but:pre-commit installlocally.gitignoredidn't block.txtfilesThis PR closes all three gaps.
Test plan
*.txtfiles are ignored by git (except Helm NOTES.txt)Authorization=Basic <base64>patterns