fix(dev): bake WalletConnect project ID into frontend dev builds#591
Merged
Conversation
OisinKyne
approved these changes
Jun 3, 2026
Contributor
OisinKyne
left a comment
OisinKyne
left a comment
There was a problem hiding this comment.
I wasn't thinking about the local dev front end flow when i closed this earlier, my b.
`just dev-frontend` / `dev-frontend-rebuild` build the local FE image but never passed NEXT_PUBLIC_WALLET_CONNECT_PROJECT_ID, so the dev image shipped with the wallet UI disabled even though the FE Dockerfile already consumes the arg (ARG -> ENV -> `pnpm run build`). Resolve the ID at build time (env NEXT_PUBLIC_WALLET_CONNECT_PROJECT_ID -> env WALLET_CONNECT_PROJECT_ID -> frontend repo .env.local) and pass it as a --build-arg. The ID is public by design (browsers use it to reach WalletConnect) but stays out of tracked obol-stack files. Factor the two near-identical recipes into a shared private recipe `_dev-frontend-build no_cache set_image` to avoid duplicating the resolver. Scope: local dev iteration only; the production release image is injected separately in the frontend repo's own build.
OisinKyne
force-pushed
the
fix/walletconnect-dev-build-arg
branch
from
dbe0d8c to
2fcda71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redo of #579, scoped to the local dev iteration path.
just dev-frontend/dev-frontend-rebuildbuild the local FE image but never passedNEXT_PUBLIC_WALLET_CONNECT_PROJECT_ID, so dev images shipped with the wallet UI disabled — even though the FEDockerfilealready consumes the arg (ARG→ENV→pnpm run build).NEXT_PUBLIC_WALLET_CONNECT_PROJECT_IDenv →WALLET_CONNECT_PROJECT_IDenv → frontend repo.env.local.--build-arg. The ID is public by design (browsers use it to reach WalletConnect) but stays out of tracked obol-stack files._dev-frontend-build no_cache set_image(vs. Pass WalletConnect project ID to frontend dev build #579 which duplicated the resolver into both recipes).Scope
Local dev iteration only. The production release image is injected separately in the frontend repo's own build (per the discussion on #579).
Validation
just --summary/--listparse cleanly;_dev-frontend-buildstays private.just --dry-run dev-frontend→ cache + set-image;dev-frontend-rebuild→--no-cache+ skip-set-image..env.local.docker build --build-arg …against the FE repo → confirmed the project ID is baked into the compiled.next/staticbundle.