fix(auth): session-expired wording + auto-redirect to /login#87
Merged
Conversation
…ssion expiry
requireAuth used to return the same "invalid or revoked key" message for
both paths — confusing for dashboard users whose session expired (they
never minted a key). Now the middleware:
- 401 + code: 'key_invalid' when the request sent an
Authorization: Bearer header
- 401 + code: 'session_expired' when only a cookie was present
- 401 (no code) "authentication required" when neither was sent
The dashboard's central fetch wrapper (src/ui/api.ts apiFetch) inspects
401 responses and, on code: 'session_expired', hash-routes to #/login.
Without this, an expired session leaves the dashboard polling endlessly
in a confused state. apiFetch is now used everywhere in api.ts and from
list.ts's row-edit fetch. Other UI entry points already handle 401
explicitly (checkAuth in app.ts) so they don't double-redirect.
Test: tests/integration/auth-error-codes.it.spec.ts covers all three
paths (no creds, bad Bearer, bad cookie).
Closes friction #19, #20.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes friction #19 (confusing "invalid or revoked key" for expired sessions) and #20 (no auto-redirect to login on session expiry). Two-part fix:
Server (src/middleware/auth.ts): requireAuth now distinguishes credential sources:
{ code: 'key_invalid' }{ code: 'session_expired' }Client (src/ui/api.ts): new exported
apiFetchshim inspects 401 responses and hash-routes to#/loginoncode: 'session_expired'. All internal fetch calls in api.ts now go through it. list.ts's monitor-detail fetch also uses it. Other UI surfaces (checkAuth in app.ts, login/setup endpoints) handle 401 explicitly already.Test plan
tests/integration/auth-error-codes.it.spec.ts— 3 new specs covering no-creds, bad-Bearer, bad-cookie paths. All pass locally.tsc --noEmit,format:checkclean#/logininstead of a broken state.🤖 Generated with Claude Code