test(v1.27.1): close SSE verification gaps + scrub private-repo paths#98
Merged
Conversation
… from public artifacts
Three new integration specs verify code paths that shipped untested
in v1.26.0+v1.26.1:
- tests/integration/sse-processor-emits.it.spec.ts (V4, 6 specs)
Each of the 7 master-path processors emits 'execution' on the
bus. Boots startWorkers + scheduler, inserts one monitor per
type, asserts the emit fires with matching type+monitorId.
QA deferred (Playwright runtime cost).
- tests/integration/sse-agent-dispatch.it.spec.ts (V1, 6 specs)
Multi-region writeAgentResult emits 'execution' for each of
url/api/tcp/udp/db/tls. Inserts region + monitor + PENDING
execution per type, calls writeAgentResult directly, asserts
type+monitorId+regionId on the event.
- tests/integration/sse-region-status.it.spec.ts (V2, 3 specs)
tickRegionStatus fires 'region' events only on transitions.
Catches missing first-sweep silence, missing transitions, and
spurious re-emits.
V3 (heartbeat OVERDUE→UP browser-level e2e) skipped with a clear
comment — DB confirms the flip on schedule and bus emits fire, but
headless Playwright tab-throttling makes the 30-90s wait flaky.
Follow-up paths noted inline.
src/scheduler.ts: tickRegionStatus exported for direct test
invocation, marked "Exported for tests; internal use only."
Also a housekeeping pass on public artifacts to remove leaked
private-repo path references:
- CHANGELOG.md: dropped two `observeone-context/...` references
in older release notes (v1.23.0 audit pointer, "Older" section).
- docs/multi-region.md: dropped the design-doc pointer.
- CONTRIBUTING.md: replaced the internal-skill pointer with the
actual release-flow steps inline.
- tests/ui/import-from-saas.e2e.spec.ts: dropped the gap-2
pointer from a header comment.
After this release, every SSE-emit site shipped in v1.26.x has at
least one behaviour-level test; total SSE coverage is 22 specs
across 5 files.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the SSE verification gap honestly. v1.26.0+v1.26.1 shipped 6 processor emits + 6 agent-dispatch branches + a region-status sweep without behaviour-level tests. This PR adds them.
tests/integration/sse-processor-emits.it.spec.tstests/integration/sse-agent-dispatch.it.spec.tstests/integration/sse-region-status.it.spec.tstests/ui/sse-live-updates.e2e.spec.tsV3 is the only one without an end-to-end assertion. DB confirms the heartbeat flips on schedule + bus emits fire correctly, but headless Playwright tab-throttling makes the 30-90s wait flaky in CI. Skipped with a clear comment + follow-up paths inline.
Total SSE coverage after this PR: 22 specs across 5 files.
Internal
tickRegionStatus()insrc/scheduler.tsexported for direct test invocation.Housekeeping
Scrubbed leaked private-repo path references from public artifacts:
CHANGELOG.md— dropped twoobserveone-context/...pointers in older release notesdocs/multi-region.md— dropped the design-doc pointerCONTRIBUTING.md— replaced an internal-skill pointer with the actual release-flow steps inlinetests/ui/import-from-saas.e2e.spec.ts— dropped a gap-2 pointer from a header commentTest plan
🤖 Generated with Claude Code