Add accumulated changes to main #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ooipy into download_scripts
for more information, see https://pre-commit.ci
Dev environment setup
…ooipy into download_scripts
for more information, see https://pre-commit.ci
…ooipy into download_scripts
Add download scripts to ooipy
for more information, see https://pre-commit.ci
merging in pre-commit changes from master
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into status_bar
John-Ragland
changed the title
1. develop OOIPY -> install OOIPY 2. init.py -> __init__.py 3. dev-requirements.txt installation added in.
added progress bar to get_acoustic_data
Changed development environment setup procedure
|
Hey @lsetiawan, this is a large accumulation of changes that we've made over that past couple of months. (as mentioned above, we're going to change our git workflow in the future to just do all of our PRs into main). I think we're ready to merge this, and wanted to see if there was anything else you think we should change before releasing the new version. |
|
Sounds good. I'll take a look real quick. Thanks for pinging me 😄 |
lsetiawan
reviewed
Aug 28, 2023
lsetiawan
reviewed
Aug 28, 2023
lsetiawan
reviewed
Aug 28, 2023
lsetiawan
reviewed
Aug 28, 2023
lsetiawan
reviewed
Aug 28, 2023
lsetiawan
reviewed
Aug 28, 2023
lsetiawan
reviewed
Aug 28, 2023
lsetiawan
reviewed
Aug 28, 2023
lsetiawan
reviewed
Aug 28, 2023
lsetiawan
reviewed
Aug 28, 2023
lsetiawan
reviewed
Aug 28, 2023
1. Python version 3.7 -> 3.9 and above 2. Python version 3.10 added for env creation.
Better documentation for function return values
Changed function code for readability
|
Thanks for your comments @lsetiawan, helps to have your perspective! I have incorporated these changes |
Incorporate changes from Don's review of PR#150
anishdixit-uw
approved these changes
Aug 28, 2023
lsetiawan
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merging all of our recent updates into the master branch