Skip to content

bug: add size info #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kan-fu merged 1 commit into from
Oct 2, 2025
Merged

bug: add size info #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/onc/modules/_OncDelivery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,8 @@ def _printProductOrderStats(self, fileList: list, runInfo: dict):
print(f"Total download Time: {txtDownTime}")

# Print size and count of files
print(f"{downloadCount} files ({humanize.naturalsize(size)}) downloaded")
natural_size = humanize.naturalsize(size, binary=True)
print(f"{downloadCount} files ({natural_size}) downloaded")
else:
print("No files downloaded.")

Expand Down
2 changes: 1 addition & 1 deletion src/onc/modules/_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def saveAsFile(
raise FileExistsError(filePath)

start = time.time()
size = 0
size = len(response.content)
with open(filePath, "wb") as file:
file.write(response.content)

Expand Down
2 changes: 2 additions & 0 deletions tests/data_product_delivery/test_data_product_delivery_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ def test_valid_no_metadata(requester, params, expected_keys_download_results, ut
assert data["downloadResults"][0]["index"] == "1"
assert data["downloadResults"][0]["downloaded"] is True

assert data["stats"]["totalSize"] != 0

assert util.get_download_files_num(requester) == 2, "The first two are png files."

util.assert_dict_key_types(
Expand Down