Feat/sync #32
Feat/sync #32
Conversation
…lasticdb-tvl Feature/add elasticdb tvl
…umentId Issue 501 - C2D getJobStatus - did vs documentId vs agreementId
…tem-test-nonce fix system tests. Running old version of node?
…ter-index-log Add cleaner logging when idexing and getting/updating block info from db
…ndex-chain-improv improve reindex command, optional block, also check if thread is running
…hboard-hash fix dashboard hash out of sync
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }) | ||
| } else if (filter.includes(':=[')) { | ||
| ;[field, value] = filter.split(':=[') | ||
| const values = value.replace(']', '').split(',') |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we need to ensure that all occurrences of the closing bracket (]) in the value string are replaced. This can be achieved by using a regular expression with the global flag (g). This change will ensure that all instances of the closing bracket are replaced, not just the first one.
| @@ -29,3 +29,3 @@ | ||
| ;[field, value] = filter.split(':=[') | ||
| const values = value.replace(']', '').split(',') | ||
| const values = value.replace(/\]/g, '').split(',') | ||
| elasticsearchQuery.query.bool.filter.push({ |
| } | ||
| } catch (error) { | ||
| HTTP_LOGGER.error(error.message) | ||
| res.status(500).send(error) |
Check warning
Code scanning / CodeQL
Information exposure through a stack trace Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we need to ensure that stack traces or any sensitive information contained in the error object are not exposed to the client. Instead, we should log the error details on the server and send a generic error message to the client.
- Modify the catch block to log the error details using
HTTP_LOGGER.errorand send a generic error message to the client. - Ensure that the error message sent to the client does not contain any sensitive information.
| @@ -30,4 +30,4 @@ | ||
| } catch (error) { | ||
| HTTP_LOGGER.error(error.message) | ||
| res.status(500).send(error) | ||
| HTTP_LOGGER.error(error.stack || error.message) | ||
| res.status(500).send("An unexpected error occurred") | ||
| } |
| }) | ||
| } | ||
|
|
||
| app.use('/dashboard', serveIndexHtml) |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| } | ||
|
|
||
| app.use('/dashboard', serveIndexHtml) | ||
| app.use('/controlpanel', serveIndexHtml) |
Check failure
Code scanning / CodeQL
Missing rate limiting High
sync from ocean node community version