CommitToGit: Handle missing destination Path#1967
Merged
Merged
Conversation
flin-8
approved these changes
May 26, 2026
Contributor
flin-8
left a comment
flin-8
left a comment
There was a problem hiding this comment.
LGTM , just add comments in the test & code to explain why we expect nulls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out Server will remove empty strings from properties/variables - given the destinationPath is (now) allowed to be empty, Calamari needs to expect that it may be missing.
If it is missing, Calamari should assume an empty string.