Python update progress#939
Closed
IsaacCalligeros95 wants to merge 2 commits intomainfrom
Closed
Conversation
IsaacCalligeros95
changed the title
Documentation and code suggest that message is optional to updateprogress. However, when not providing a message to updateprogress it fails with an error from encode() as message is None. This is fixed here, by using an empty string as default for message instead of None.
IsaacCalligeros95
force-pushed
the
_smlng/python-updateprogress
branch
from
8ca4a2d to
36c17ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR from community member @smlng. For Teamcity and security protocols in place this has to be re-created.