Skip to content

Fixing two bugs#1010

Merged
harrisonmeister merged 2 commits intomasterfrom
bug-ssrs
Sep 25, 2020
Merged

Fixing two bugs#1010
harrisonmeister merged 2 commits intomasterfrom
bug-ssrs

Conversation

@twerthi
Copy link
Copy Markdown
Contributor

@twerthi twerthi commented Sep 24, 2020


Step template checklist

  • Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
    • NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
  • Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
  • Parameter names should not start with $
  • Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
  • LastModifiedBy field must be present, and (optionally) updated with the correct author
  • If a new Category has been created:
    • An image with the name {categoryname}.png must be present under the step-templates/logos folder
    • The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it

Fixes # . If there is an open issue that this PR fixes add it here, otherwise just remove this line

@twerthi twerthi closed this Sep 25, 2020
@twerthi
Copy link
Copy Markdown
Contributor Author

twerthi commented Sep 25, 2020

Not really a bug.

@twerthi twerthi reopened this Sep 25, 2020
@harrisonmeister harrisonmeister self-assigned this Sep 25, 2020
Copy link
Copy Markdown
Contributor

@harrisonmeister harrisonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harrisonmeister harrisonmeister merged commit 4f28a75 into master Sep 25, 2020
@harrisonmeister harrisonmeister deleted the bug-ssrs branch September 25, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants